feat(assert): cdk assert: implement 'haveOutput' assertion (#1906) #5366

ilya-v-trofimov · 2019-12-11T01:30:42Z

Implements an ability to assert stack outputs

Fixes #1906

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Commit Message

feat(assert): cdk assert: implement 'haveOutput' assertion (#5366)

Implements an ability to assert presence of stack outputs with specific
properties being present.

Fixes #1906

mergify · 2019-12-11T01:31:20Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-12-11T01:59:20Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-12-16T12:32:54Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:00:40Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:52:59Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:38:39Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:52:03Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T15:17:06Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-12-16T17:59:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller

Hey!

Thanks for the submission! This is an interesting feature, but I reckon we can make it a little more powerful even...

exportName can be a string-valued expression (very much like exportValue can)
I wonder if there's any value in allowing outputName to be a RegExp so we can pattern-match it
I wonder if there's any value in checking for absense of an exportName

packages/@aws-cdk/assert/README.md

packages/@aws-cdk/assert/test/test.have-output.ts

RomainMuller · 2019-12-18T08:55:47Z

packages/@aws-cdk/assert/test/test.have-output.ts

@@ -0,0 +1,163 @@
+import cxapi = require('@aws-cdk/cx-api');
+import {writeFileSync} from 'fs';


Suggested change

import {writeFileSync} from 'fs';

import { writeFileSync } from 'fs';

packages/@aws-cdk/assert/test/test.have-output.ts

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

Pull request has been modified.

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

aws-cdk-automation · 2019-12-21T07:36:22Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

…tions

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

aws-cdk-automation · 2019-12-21T07:42:09Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-21T07:47:36Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

….com:ilya-v-trofimov/aws-cdk into ilya-v-trofimov/feature-haveOutput-assertion

aws-cdk-automation · 2019-12-21T10:25:04Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-21T10:29:07Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-21T10:51:18Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-24T10:52:46Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-27T16:30:53Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…rface

aws-cdk-automation · 2019-12-31T09:53:45Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-31T10:23:06Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-03T15:15:38Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-10T13:09:42Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller · 2020-01-10T14:03:53Z

Altered the code a little bit to be able to offer the jest extension, too. Once the validation build is though, this can be merged !!

aws-cdk-automation · 2020-01-10T14:08:06Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Pull request has been modified.

aws-cdk-automation · 2020-01-13T09:59:21Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-13T09:59:53Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-01-13T10:19:51Z

Thank you for contributing! Your pull request is now being automatically merged.

mergify · 2020-01-13T10:27:33Z

Command refresh: success

Hey, I reacted but my real name is @Mergifyio

Implements an ability to assert presence of stack outputs with specific properties being present. Fixes #1906

feat(assert): cdk assert: implement 'haveOutput' assertion (aws#1906)

c1bd451

ilya-v-trofimov requested a review from RomainMuller as a code owner December 11, 2019 01:30

SomayaB assigned RomainMuller Dec 11, 2019

shivlaks mentioned this pull request Dec 12, 2019

@aws-cdk/assert add toHaveOutput #5389

Closed

2 tasks

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

201582f

RomainMuller previously requested changes Dec 18, 2019

View reviewed changes

Update README

6efaca2

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

ilya-v-trofimov and others added 2 commits December 21, 2019 18:26

remove blank line as per review recommendations

7a83f5c

Update TSDocs as per review comments

e2b00b1

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

ilya-v-trofimov and others added 3 commits December 21, 2019 18:39

feat(assert): haveOutput - Update README as per review comments

0a5ea1b

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

feat(assert): haveOutput - remove blank line as per review recommenda…

f21aedc

…tions

feat(assert): haveOutput - Update TSDocs as per review comments

b214ab2

Co-Authored-By: Romain Marcadier-Muller <romain.muller@telecomnancy.net>

ilya-v-trofimov added 2 commits December 21, 2019 21:04

feat(assert): haveOutput - fixing/refactoring as per review comments

ccc6830

Merge branch 'ilya-v-trofimov/feature-haveOutput-assertion' of github…

8663c31

….com:ilya-v-trofimov/aws-cdk into ilya-v-trofimov/feature-haveOutput-assertion

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

0a2bc8e

feat(assert): haveOutput - fixing import style in test file

d277197

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

711a5d6

Update README.md

af838c4

ilya-v-trofimov and others added 2 commits December 31, 2019 20:49

feat(assert): haveOutput - fixing TSDoc for HaveOutputProperties inte…

d44f849

…rface

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

fde7e9d

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

0c7fb09

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

d912431

make the assetion jest-friendly

7965c41

RomainMuller previously approved these changes Jan 10, 2020

View reviewed changes

RomainMuller added 2 commits January 13, 2020 10:23

adjust jest coverage threshold

c0fa062

Merge branch 'master' into ilya-v-trofimov/feature-haveOutput-assertion

82f470d

RomainMuller approved these changes Jan 13, 2020

View reviewed changes

mergify bot merged commit ee6decb into aws:master Jan 13, 2020

iliapolo pushed a commit that referenced this pull request Jan 13, 2020

feat(assert): cdk assert: implement 'haveOutput' assertion (#5366)

7ed33cb

Implements an ability to assert presence of stack outputs with specific properties being present. Fixes #1906

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(assert): cdk assert: implement 'haveOutput' assertion (#1906) #5366

feat(assert): cdk assert: implement 'haveOutput' assertion (#1906) #5366

ilya-v-trofimov commented Dec 11, 2019 •

edited by RomainMuller

Loading

mergify bot commented Dec 11, 2019

aws-cdk-automation commented Dec 11, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 16, 2019

RomainMuller left a comment

RomainMuller Dec 18, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 21, 2019

aws-cdk-automation commented Dec 24, 2019

aws-cdk-automation commented Dec 27, 2019

aws-cdk-automation commented Dec 31, 2019

aws-cdk-automation commented Dec 31, 2019

aws-cdk-automation commented Jan 3, 2020

aws-cdk-automation commented Jan 10, 2020

RomainMuller commented Jan 10, 2020

aws-cdk-automation commented Jan 10, 2020

aws-cdk-automation commented Jan 13, 2020

aws-cdk-automation commented Jan 13, 2020

mergify bot commented Jan 13, 2020

mergify bot commented Jan 13, 2020

		@@ -0,0 +1,163 @@
		import cxapi = require('@aws-cdk/cx-api');
		import {writeFileSync} from 'fs';

	import {writeFileSync} from 'fs';
	import { writeFileSync } from 'fs';

feat(assert): cdk assert: implement 'haveOutput' assertion (#1906) #5366

feat(assert): cdk assert: implement 'haveOutput' assertion (#1906) #5366

Conversation

ilya-v-trofimov commented Dec 11, 2019 • edited by RomainMuller Loading

Commit Message

mergify bot commented Dec 11, 2019

aws-cdk-automation commented Dec 11, 2019

AWS CodeBuild CI Report

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 16, 2019

AWS CodeBuild CI Report

RomainMuller left a comment

Choose a reason for hiding this comment

RomainMuller Dec 18, 2019

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 21, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 24, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 27, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 3, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 10, 2020

AWS CodeBuild CI Report

RomainMuller commented Jan 10, 2020

aws-cdk-automation commented Jan 10, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 13, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 13, 2020

AWS CodeBuild CI Report

mergify bot commented Jan 13, 2020

mergify bot commented Jan 13, 2020

ilya-v-trofimov commented Dec 11, 2019 •

edited by RomainMuller

Loading