Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ECS): fix wrong comparison, AWS Fargate vs Amazon ECS #5393

Closed
sukjae opened this issue Dec 12, 2019 · 1 comment · Fixed by #5394
Closed

docs(ECS): fix wrong comparison, AWS Fargate vs Amazon ECS #5393

sukjae opened this issue Dec 12, 2019 · 1 comment · Fixed by #5394
Assignees
@SoManyHs @piradeepk
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container docs/generated Related to the generated API Reference documentation feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@sukjae
Copy link
Contributor

sukjae commented Dec 12, 2019

link to reference doc page:

https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecs-readme.html

describe your issue:

in the middle of document, there is comparison between AWS Fargate vs Amazon ECS.

but, in my opinion it should be AWS Fargate vs Amazon EC2.

also, following sentence right after title should be changed.

There are two sets of constructs in this library; one to run tasks on Amazon ECS and one to run tasks on AWS Fargate.

to

There are two sets of constructs in this library; one to run tasks on Amazon EC2 and one to run tasks on AWS Fargate.

This is a 📕 documentation issue
@sukjae sukjae added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2019
@sukjae sukjae mentioned this issue Dec 12, 2019
Merged
@SomayaB SomayaB added @aws-cdk/aws-ecs Related to Amazon Elastic Container in-progress This issue is being actively worked on. docs/generated Related to the generated API Reference documentation labels Dec 13, 2019
@hencrice
Copy link
Contributor

Approved PR, waiting on checks. Removing "needs-triage" label

@hencrice hencrice removed the needs-triage This issue or PR still needs to be triaged. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container docs/generated Related to the generated API Reference documentation feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ecs): correct doc with proper comparison between launch types
5 participants
@hencrice @sukjae @SomayaB @SoManyHs @piradeepk