feat(ec2): `VpcEndpointService` construct #5498

flemjame-at-amazon · 2019-12-20T02:49:20Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

L2 construct for VPC Endpoint Service which abstracts away the following code:

CfnVPCEndpointService vpcEndpointService = new CfnVPCEndpointService(this, "VPC Endpoint Service", CfnVPCEndpointServiceProps.builder()
                .acceptanceRequired(false)
                .networkLoadBalancerArns(Arrays.asList("load-balancer-arn"))
                .build());
CfnVPCEndpointServicePermissions principals = new CfnVPCEndpointServicePermissions(this, "Endpoint Service Whitelisted Accounts", CfnVPCEndpointServicePermissionsProps.builder()
                .serviceId(vpcEndpointService.getRef())
                .allowedPrincipals(ArrayList<String>())
                .build());

And makes it into:

VpcEndpointService = new VpcEndpointService(this, "Endpoint Service", VpcEndpointServiceProps.builder()
                .networkLoadBalancerArns(Arrays.asList("load-balancer-arn"))
                .acceptanceRequired(false)
                .allowedPrincipals(ArrayList<ArnPrincipal>())
                .build());

I was not able to make networkLoadBalancerArns take a list of INetworkLoadBalancer due to a cyclic dependency between aws-ec2 and aws-elasticloadbalancingv2.

EDIT:

New invocation after review feedback and subsequent changes:

VpcEndpointService = new VpcEndpointService(this, "Endpoint Service", VpcEndpointServiceProps.builder()
                .vpcEndpointServiceLoadBalancers(ArrayList<IVpcEndpointServiceLoadBalancer>())
                .acceptanceRequired(false)
                .allowedPrincipals(ArrayList<ArnPrincipal>())
                .build());

vpcEndpointServiceLoadBalancers accepts a list of NetworkLoadBalancer as an argument.

Commit Message

feat(ec2): VpcEndpointService construct

Add an experimental VpcEndpointService construct, to allow exposing Network Load Balancers as endpoints in a VPC.

packages/@aws-cdk/aws-ec2/lib/vpc-endpoint-service.ts

packages/@aws-cdk/aws-ec2/test/test.vpc-endpoint-service.ts

aws-cdk-automation · 2019-12-20T03:22:50Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-20T03:25:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-20T05:03:07Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-20T14:59:33Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-23T22:28:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-ec2/lib/vpc-endpoint-service.ts

Pull request has been modified.

aws-cdk-automation · 2019-12-30T15:34:56Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-31T17:00:44Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-31T17:00:58Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-31T17:05:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-31T17:15:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-ec2/lib/vpc-endpoint-service.ts

rix0rrr · 2020-01-06T13:15:49Z

Also can you please mark all new APIs @experimental ?

Pull request has been modified.

aws-cdk-automation · 2020-01-06T14:59:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-06T16:06:07Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-06T16:08:12Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-06T16:48:25Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-06T18:12:46Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-01-07T09:13:34Z

Thank you for contributing! Your pull request is now being automatically merged.

aws-cdk-automation · 2020-01-07T09:54:17Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-01-07T09:54:40Z

Thank you for contributing! Your pull request is now being automatically merged.

aws-cdk-automation · 2020-01-07T09:58:30Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

EC2 Default User and others added 4 commits December 18, 2019 19:51

feat(ec2): add vpc endpoint service construct

09914ba

Need to add the CDK suffixes to the expected

58cf9de

Use the CDK magic strings

48672d9

Changing to ArnPrincipal instead of string

118ca7f

flemjame-at-amazon requested a review from rix0rrr as a code owner December 20, 2019 02:49

Merge branch 'master' into add-vpc-endpoint-service

056c86c

rhboyd reviewed Dec 20, 2019

View reviewed changes

Review feedback

aab1ee6

Merge branch 'master' into add-vpc-endpoint-service

406b480

SomayaB assigned rix0rrr Dec 20, 2019

Merge branch 'master' into add-vpc-endpoint-service

fe8b2e0

rix0rrr previously requested changes Dec 27, 2019

View reviewed changes

packages/@aws-cdk/aws-ec2/lib/vpc-endpoint-service.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-ec2/lib/vpc-endpoint-service.ts Outdated Show resolved Hide resolved

Merge branch 'master' into add-vpc-endpoint-service

73ee41f

flemjame-at-amazon and others added 7 commits December 30, 2019 20:03

Removing tests and adding IVpcEndpointService

7d0878d

NLB inherits IVpcEndpointServiceLoadBalancer

f69411d

Update tests

c2983ec

Add integration tests back

edc37ba

Update readme

0ab1d09

Small readme addition

e388f79

Merge branch 'master' into add-vpc-endpoint-service

1e03f25

flemjame-at-amazon requested a review from rix0rrr January 2, 2020 18:01

rix0rrr previously requested changes Jan 6, 2020

View reviewed changes

Merge branch 'master' into add-vpc-endpoint-service

a92196f

flemjame-at-amazon added 3 commits January 6, 2020 15:16

Review feedback

0ee8de4

Not sure why that changed

a776e7e

Mark as experimental

01a1b0e

flemjame-at-amazon requested a review from rix0rrr January 6, 2020 15:49

Oops, shouldn't have marked that as experimental

5601ae6

Anothr thing to not mark as experimental

ecaa6d1

rix0rrr changed the title ~~feat(ec2): add vpc endpoint service L2 construct~~ feat(ec2): VpcEndpointService construct Jan 7, 2020

rix0rrr approved these changes Jan 7, 2020

View reviewed changes

mergify bot added 2 commits January 7, 2020 09:14

Merge branch 'master' into add-vpc-endpoint-service

bf801a8

Merge branch 'master' into add-vpc-endpoint-service

434b47b

mergify bot merged commit a2713f3 into aws:master Jan 7, 2020

flemjame-at-amazon deleted the add-vpc-endpoint-service branch January 7, 2020 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ec2): `VpcEndpointService` construct #5498

feat(ec2): `VpcEndpointService` construct #5498

flemjame-at-amazon commented Dec 20, 2019 •

edited by rix0rrr

Loading

aws-cdk-automation commented Dec 20, 2019

aws-cdk-automation commented Dec 20, 2019

aws-cdk-automation commented Dec 20, 2019

aws-cdk-automation commented Dec 20, 2019

aws-cdk-automation commented Dec 23, 2019

aws-cdk-automation commented Dec 30, 2019

aws-cdk-automation commented Dec 31, 2019

aws-cdk-automation commented Dec 31, 2019

aws-cdk-automation commented Dec 31, 2019

aws-cdk-automation commented Dec 31, 2019

rix0rrr commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

mergify bot commented Jan 7, 2020

aws-cdk-automation commented Jan 7, 2020

mergify bot commented Jan 7, 2020

aws-cdk-automation commented Jan 7, 2020

feat(ec2): VpcEndpointService construct #5498

feat(ec2): VpcEndpointService construct #5498

Conversation

flemjame-at-amazon commented Dec 20, 2019 • edited by rix0rrr Loading

Commit Message

aws-cdk-automation commented Dec 20, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 20, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 20, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 20, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 23, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 30, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 31, 2019

AWS CodeBuild CI Report

rix0rrr commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

mergify bot commented Jan 7, 2020

aws-cdk-automation commented Jan 7, 2020

AWS CodeBuild CI Report

mergify bot commented Jan 7, 2020

aws-cdk-automation commented Jan 7, 2020

AWS CodeBuild CI Report

feat(ec2): `VpcEndpointService` construct #5498

feat(ec2): `VpcEndpointService` construct #5498

flemjame-at-amazon commented Dec 20, 2019 •

edited by rix0rrr

Loading