Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): unable to associate RestApi as a route53 target for late bound domains #5555

Merged
merged 3 commits into from
Jan 14, 2020
Merged

fix(apigateway): unable to associate RestApi as a route53 target for late bound domains #5555

merged 3 commits into from
Jan 14, 2020

Conversation

netroy
Copy link
Contributor

@netroy netroy commented Dec 26, 2019 •
edited by nija-at
Loading

fixes #5539

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@netroy netroy requested review from eladb and nija-at as code owners December 26, 2019 12:37
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title fix(apigateway): allow adding custom domain after the constructor call feat(apigateway): allow adding custom domain after the constructor call Jan 2, 2020
@nija-at nija-at changed the title feat(apigateway): allow adding custom domain after the constructor call fix(apigateway): allow adding custom domain after the constructor call Jan 2, 2020
@nija-at nija-at changed the title fix(apigateway): allow adding custom domain after the constructor call fix(apigateway): RestApi does not record DomainName added via addDomainName() Jan 2, 2020
nija-at
nija-at previously requested changes Jan 2, 2020
View reviewed changes
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title fix(apigateway): RestApi does not record DomainName added via addDomainName() fix(apigateway): addDomainName() record the domain name Jan 2, 2020
@nija-at nija-at changed the title fix(apigateway): addDomainName() record the domain name fix(apigateway): addDomainName() fails to record the domain name Jan 2, 2020
@mergify mergify bot dismissed nija-at’s stale review January 2, 2020 17:04

Pull request has been modified.

@netroy netroy requested a review from nija-at January 2, 2020 17:05
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title fix(apigateway): addDomainName() fails to record the domain name fix(apigateway): unable to associate RestApi as a route53 target for late bound domains Jan 6, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@netroy
Copy link
Contributor Author

netroy commented Jan 8, 2020

@nija-at rebased. Can you have a look at it again, please?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously approved these changes Jan 13, 2020
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review January 13, 2020 12:08

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously approved these changes Jan 14, 2020
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review January 14, 2020 15:40

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit c02741e into aws:master Jan 14, 2020
@netroy netroy deleted the fix-5539 branch January 14, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@eladb eladb Awaiting requested review from eladb

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"API does not define a default domain name" for Apigateway alias target
3 participants
@netroy @aws-cdk-automation @nija-at