Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): authorizer name is not optional #5731

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jan 9, 2020

The authorizer name property is marked as optional in CloudFormation
docs but is actually not.

Use the TokenAuthorizer node's uniquId as the default.

fixes #5678


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The authorizer name property is marked as optional in CloudFormation
docs but is actually not.

Use the TokenAuthorizer node's uniquId as the default.

fixes #5678
@nija-at nija-at requested a review from eladb January 9, 2020 12:37
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 21c425e into master Jan 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot deleted the nija-at/apigateway-authorizername branch January 9, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CfnAuthorizer: name is required by CloudFormation
3 participants