fix(cloudwatch): cross-account metrics in env-agnostic stack #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid generating unnecessary diffs to currently-deployed CloudWatch dashboards, in #5628 when adding support for cross-region/cross-account metrics, we only selectively render the new attributes into the graph (only when we estimate it will make a difference). The method chosen was: Render account/region if they're *definitely* different. However, this has the side effect that the new region and account attributes don't work at all in environment-agnostic stacks (because we won't know whether they'll be different or not, and we assume they will be). Whether the original behavior was wrong or not can be debated, but it's unintuitive for sure: users put in values that don't come back out in the usual, getting-started case. In this PR, change the decision to: Don't render account/region if they're *definitely* the same. This will fix the case of manual input to `Metric`, and since `attachTo()` won't take account and region from environment-agnostic stacks anyway, it also won't introduce unwanted diffs in most cases.
rix0rrr
requested review from
RomainMuller,
skinny85,
eladb,
iliapolo,
MrArnoldPalmer and
nija-at
RomainMuller
approved these changes
Jan 13, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid generating unnecessary diffs to currently-deployed
CloudWatch dashboards, in #5628 when adding support for
cross-region/cross-account metrics, we only selectively render the new
attributes into the graph (only when we estimate it will make a difference).
The method chosen was:
However, this has the side effect that the new region and account
attributes don't work at all in environment-agnostic stacks (because we
won't know whether they'll be different or not, and we assume they will
be).
Whether the original behavior was wrong or not can be debated,
but it's unintuitive for sure: users put in values that don't come
back out in the usual, getting-started case.
In this PR, change the decision to:
This will fix the case of manual input to
Metric, and sinceattachTo()won't take account and region from environment-agnosticstacks anyway, it also won't introduce unwanted diffs in most cases.
Fixes #5747.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license