Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new cdk-bootstrap: tag all resources #5809

Closed
2 tasks
eladb opened this issue Jan 15, 2020 · 4 comments
Closed
2 tasks

new cdk-bootstrap: tag all resources #5809

eladb opened this issue Jan 15, 2020 · 4 comments
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@eladb
Copy link
Contributor

eladb commented Jan 15, 2020

In the new bootstrap stack designed as part of #3437 and #4461 we should add a tag to all resources that will allow us to easily identify them for various purposes.

Use Case

One concrete purpose is to be able to identify asset repositories (ECR/S3) when doing garbage collection.

Proposed Solution

Just add tags.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@eladb eladb added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 15, 2020
@skinny85
Copy link
Contributor

Any specific requirements for the tags? Any format that the garbage collection expects?

@SomayaB SomayaB added package/tools Related to AWS CDK Tools or CLI and removed needs-triage This issue or PR still needs to be triaged. labels Jan 15, 2020
@skinny85 skinny85 added the effort/small Small work item – less than a day of effort label Feb 6, 2020
@skinny85 skinny85 added the p2 label Sep 11, 2020
@ganeshnj
Copy link

I was looking something similar, is there an option/configuration exists where I can set custom tag/tags which will be applied to all the resources that CDK creates?

@adamnovak
Copy link
Contributor

I think the CDK bootstrap and deploy commands have a --tags option that can do what @ganeshnj wants.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 4, 2023
@github-actions github-actions bot closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@skinny85 @eladb @adamnovak @ganeshnj @SomayaB