fix(ec2): add MachineImage factory, document instance replacement
#6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some MachineImages get updated automatically (causing unexpected instance replacement), and some don't. Update the documentation to very clearly note which image is which, and that using a particular type of image may cause your instance to be replaced. Also add a class with static factory functions to make an enum-like pattern, to be in line with other places where the user has a choice of implementations. Fixes #5675. Also note that VPC lookups are cached, which hopefully addresses #6025.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NetaNir
approved these changes
Feb 4, 2020
| * The VPC information will be cached in `cdk.context.json` and the same VPC | ||
| * will be used on future runs. To refresh the lookup, you will have to | ||
| * evict the value from the cache using the `cdk context` command. See | ||
| * https://docs.aws.amazon.com/cdk/latest/guide/context.html for more information. | ||
| */ |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MachineImages get updated automatically (causing unexpected
instance replacement), and some don't. Update the documentation to very
clearly note which image is which, and that using a particular type of
image may cause your instance to be replaced.
Also add a class with static factory functions to make an enum-like
pattern, to be in line with other places where the user has a choice
of implementations.
Fixes #5675.
Also note that VPC lookups are cached, which hopefully addresses #6025.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license