Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-s3-deployment resource does not properly support customer algorithm encryption #6080

Closed
2 tasks
mattsains opened this issue Feb 3, 2020 · 1 comment
Closed
2 tasks

aws-s3-deployment resource does not properly support customer algorithm encryption #6080

mattsains opened this issue Feb 3, 2020 · 1 comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@mattsains
Copy link
Contributor

Reading https://docs.aws.amazon.com/AmazonS3/latest/dev/ServerSideEncryptionCustomerKeys.html#sse-c-how-to-programmatically-intro

If you are using SSE-C, you need to specify the following metadata fields in the s3 upload:

  • algorithm (present in CDK implementation)
  • customer key (not present)
  • MD5 hash of object (not present)

Use Case

Customers who wish to do an S3 deployment with their own aes_256 key.

Proposed Solution

The following fields need to be populated when calling s3:

x-amz-server-side​-encryption​-customer-key
x-amz-server-side​-encryption​-customer-key-MD5

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@mattsains mattsains added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 3, 2020
@mattsains mattsains mentioned this issue Feb 3, 2020
Merged
@SomayaB SomayaB added the @aws-cdk/aws-s3 Related to Amazon S3 label Feb 4, 2020
@iliapolo iliapolo added the effort/small Small work item – less than a day of effort label Mar 16, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label May 19, 2020
@iliapolo iliapolo added the p1 label Aug 29, 2020
@iliapolo iliapolo removed their assignment Jun 27, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 28, 2022
@github-actions github-actions bot closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-s3 Related to Amazon S3 closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iliapolo @mattsains @SomayaB