Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing for cfnspec module generation #6198

Closed
nija-at opened this issue Feb 10, 2020 · 2 comments
Closed

testing for cfnspec module generation #6198

nija-at opened this issue Feb 10, 2020 · 2 comments
Assignees
@eladb
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI

Comments

@nija-at
Copy link
Contributor

nija-at commented Feb 10, 2020

Over time, we have built up a lot of logic in our cfnspec updates - https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/cfnspec/build-tools. However, it has no testing in place.

We should bridge that gap with any necessary refactor and, unit and integration tests.
@nija-at nija-at added the needs-triage This issue or PR still needs to be triaged. label Feb 10, 2020
@SomayaB SomayaB added package/tools Related to AWS CDK Tools or CLI feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2020
@nija-at nija-at mentioned this issue Feb 11, 2020
Merged
@nija-at nija-at assigned eladb and unassigned nija-at Feb 13, 2020
@eladb eladb changed the title cfnspec testing for its "build-tools" testing for its build-tools in cfnspec Feb 16, 2020
@eladb eladb changed the title testing for its build-tools in cfnspec testing for cfnspec module generation Feb 16, 2020
@eladb
Copy link
Contributor

eladb commented Feb 16, 2020

I would argue we have sufficient "implicit tests" for this and the unit test coverage gap is a very low risk, but I would love to hear about any use cases where a unit test would have helped us catch an issue.

@eladb eladb added the effort/medium Medium work item – several days of effort label Feb 16, 2020
@eladb
Copy link
Contributor

eladb commented Aug 17, 2020

Closing for now. @nija-at please reopen if you think we need this.

@eladb eladb closed this as completed Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eladb @nija-at @SomayaB