Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elbv2): validate rule priority is a positive number #6222

Merged
merged 6 commits into from
Feb 11, 2020
Merged

fix(elbv2): validate rule priority is a positive number #6222

merged 6 commits into from
Feb 11, 2020

Conversation

rzamana
Copy link
Contributor

@rzamana rzamana commented Feb 11, 2020

The Application Load Balancer does not accepts priority equal or less
than ZERO. Throws an error if passes ZERO or less.

closes #4246

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Moving the method logAccessLogs to the Base Load Balancer, so both types
of Load Balancer (Network and Application) can use the method.

closes #3794
The Application Load Balancer does not accepts priority equal or less
than ZERO. Throws an error if passes ZERO or less.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title fix(elbv2): Validating if priority is greater than ZERO fix(elbv2): validate rule priority is a positive number Feb 11, 2020
@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 1fbaafe into aws:master Feb 11, 2020
@rzamana rzamana deleted the elbv2_priority_check branch February 12, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Priority value for lb.addListener should be validated by CDK
3 participants