Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup DLQ for auto generated Queue in @aws-cdk_aws-ecs-patterns QueueProcessingFargateService #6352

Closed
1 of 2 tasks
SeekerWing opened this issue Feb 18, 2020 · 0 comments · Fixed by #6356
Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@SeekerWing
Copy link
Contributor

SeekerWing commented Feb 18, 2020

queue is an optional attribute for QueueProcessingFargateService, in such scenarios CDK automatically creates the queue for the customer and provides the ECS task the necessary permissions to access the queue.

Use Case

CDK aims to drive best practices in the AWS user community and i believe setting up the DLQ for the primary queue is a best practice worth providing out of the box, even without it most SQS consumers setup a custom DLQ, they shouldn't have to do it in such scenarios if CDK can do it for them.

Proposed Solution

setup DLQ for generated primary queue and setup necessary permissions and redrive policy for the same.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@SeekerWing SeekerWing added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 18, 2020
@SomayaB SomayaB added @aws-cdk/aws-ecs-patterns Related to ecs-patterns library in-progress This issue is being actively worked on. labels Feb 19, 2020
@mergify mergify bot closed this as completed in #6356 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
4 participants