Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secretsmanager: secretString should be specified directly. #6378

Closed
acomagu opened this issue Feb 20, 2020 · 1 comment
Closed

secretsmanager: secretString should be specified directly. #6378

acomagu opened this issue Feb 20, 2020 · 1 comment
Assignees
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@acomagu
Copy link
Contributor

acomagu commented Feb 20, 2020

This should work:

new secretsmanager.Secret(this, 'TemplatedSecret', {
    secretString: 'hoge',
});

The document explains why not that "this will almost always lead to the secret being surfaced in plain text and possibly committed to your source control".

But I think not "almost always". I think the one of benefits of CDK is we can do what we want programmatically in deployment process, unlike other YAML solutions. We can prepare secret string from environment variable, API response, user prompting and so on.

@acomagu acomagu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 20, 2020
@SomayaB SomayaB added the @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager label Feb 21, 2020
@skinny85 skinny85 added the effort/small Small work item – less than a day of effort label Mar 11, 2020
@skinny85
Copy link
Contributor

Duplicate of #5810

@skinny85 skinny85 marked this as a duplicate of #5810 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants