Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudformation): CloudFormation Resource Specification 11.1.0 #6424

Merged
merged 2 commits into from
Feb 24, 2020
Merged

feat(cloudformation): CloudFormation Resource Specification 11.1.0 #6424

merged 2 commits into from
Feb 24, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Feb 24, 2020 •
edited by shivlaks
Loading

Figured I'd give this a shot since I'm already making the rounds on new CloudFormation Resource Specification versions:
aws-cloudformation/cfn-lint#1380
aws-cloudformation/cfn-lint-visual-studio-code#79

brew install node yarn
git clone https://github.com/aws/aws-cdk.git
cd aws-cdk
./install.sh
cd packages/@aws-cdk/cfnspec
../../../scripts/buildup
yarn update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

eladb
eladb previously approved these changes Feb 24, 2020
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c8da41e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed eladb’s stale review February 24, 2020 20:24

Pull request has been modified.

@PatMyron PatMyron requested a review from eladb February 24, 2020 20:36
eladb
eladb approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to merge from master. Mergify does that automatically if all checks pass

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a9eeddc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks changed the title feat: CloudFormation Resource Specification 11.1.0 feat(cloudformation): CloudFormation Resource Specification 11.1.0 Feb 24, 2020
@shivlaks shivlaks merged commit ab9b77c into aws:master Feb 24, 2020
@shivlaks shivlaks mentioned this pull request Feb 26, 2020
Closed
@PatMyron PatMyron mentioned this pull request Feb 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@shivlaks shivlaks shivlaks approved these changes

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatMyron @aws-cdk-automation @eladb @shivlaks