Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): cannot use cdk docker assets as base image #6471

Merged
merged 2 commits into from
Feb 27, 2020
Merged

fix(docker): cannot use cdk docker assets as base image #6471

merged 2 commits into from
Feb 27, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Feb 26, 2020 •
edited
Loading

Ensure docker login is called before docker build to allow using cdk docker
assets as base image for other docker assets.

Fixes #6466

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
fix(docker): cannot use cdk docker assets as base image
a6ae88f 
Ensure `docker login` is called before `docker build` to allow using cdk docker
assets as base image for other docker assets.

Fixes aws#6466
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a6ae88f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rix0rrr please see this, as it may also need to be reflected in CDK-assets.

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 495c711
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 983dd40 into aws:master Feb 27, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 27, 2020 •
edited
Loading

@jogold how do you reference other assets? Their build order is not guaranteed and I would consider their local names an implementation detail (and their remote names a deployment order detail), so I'm curious how you would go about this in practice in a way that's not liable to break?

@jogold jogold deleted the docker-login-before-build branch February 27, 2020 10:58
@jogold
Copy link
Contributor Author

jogold commented Feb 27, 2020

@jogold how do you reference other assets? Their build order is not guaranteed and I would consider their local names an implementation detail (and their remote names a deployment order detail), so I'm curious how you would go about this in practice in a way that's not liable to break?

See #6466 where I describe a pattern to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credentials error when using a common docker asset as base image for other docker assets
4 participants
@jogold @aws-cdk-automation @rix0rrr @eladb