Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(certificatemanager): Route53 endpoint cannot be set and does not work for aws-cn #6480

Merged
merged 3 commits into from
Mar 11, 2020
Merged

fix(certificatemanager): Route53 endpoint cannot be set and does not work for aws-cn #6480

merged 3 commits into from
Mar 11, 2020

Conversation

brookhong
Copy link
Contributor

@brookhong brookhong commented Feb 27, 2020 •
edited
Loading

To fix #6431

We have also considered hardcode endpoint for China regions, but which may have change after Route53 officially launched in China.

Now to make this work for internal accounts(as for which Route53 in China are available), we provide a word around for users to provide endpoint from app stack.

After Route53 officially launched in China and it will also provide a decent endpoint as other regions, customers need not provide any endpoint for the parameter, just use it as for other regions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@brookhong brookhong changed the title Pass route53 endpoint to DnsValidatedCertificate to make it work for aws-cn fix(DnsValidatedCertificate) Pass route53 endpoint to DnsValidatedCertificate to make it work for aws-cn Feb 27, 2020
@brookhong brookhong changed the title fix(DnsValidatedCertificate) Pass route53 endpoint to DnsValidatedCertificate to make it work for aws-cn fix(DnsValidatedCertificate): Pass route53 endpoint to DnsValidatedCertificate to make it work for aws-cn Feb 27, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4da8e4e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d679b0c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@brookhong
Copy link
Contributor Author

Hey @shivlaks Any update?

@shivlaks
Copy link
Contributor

shivlaks commented Mar 4, 2020

Hey @shivlaks Any update?

taking a look!

@mergify mergify bot dismissed shivlaks’s stale review March 10, 2020 10:26

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 696a536
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1d4ebfe
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously requested changes Mar 10, 2020
View reviewed changes
...ws-cdk/aws-certificatemanager/lambda-packages/dns_validated_certificate_handler/lib/index.js Outdated
@@ -80,7 +80,7 @@ let report = function(event, context, responseStatus, physicalResourceId, respon
const requestCertificate = async function(requestId, domainName, subjectAlternativeNames, hostedZoneId, region) {
const crypto = require('crypto');
const acm = new aws.ACM({ region });
const route53 = new aws.Route53();
const route53 = region.startsWith("cn-") ? new aws.Route53({endpoint: "https://route53.amazonaws.com.cn"}) : new aws.Route53();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • what're the exact region(s)? is there a good reason for going with startsWith? (i.e. would all future CN regions map to the same endpoint? if not, we should be specific here)
  • how has this been tested? - I don't see Route53 as a supported service in the region table.
    • can you share any resources used in determining this endpoint?

@mergify mergify bot dismissed shivlaks’s stale review March 11, 2020 01:59

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 76bc8c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks changed the title fix(DnsValidatedCertificate): Pass route53 endpoint to DnsValidatedCertificate to make it work for aws-cn fix(certificatemanager): Route53 endpoint cannot be set and does not work for aws-cn Mar 11, 2020
shivlaks
shivlaks reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer - can you clarify why the ecs-patterns integ test expectations needed to change?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e58dcce
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4684b1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9858cdb into aws:master Mar 11, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass route53 endpoint to DnsValidatedCertificate in resource property
3 participants
@brookhong @aws-cdk-automation @shivlaks