feat(lambda): currentVersion, version.addAlias() #6771

eladb · 2020-03-17T13:45:51Z

Remaining work:

Address Deploying new version of lambda function #5334 (comment)
Retain old versions?
"A version for this Lambda function exists ( 2 ). Modify the function to create a new version."

Commit Message

It is common for AWS services to require an explicit AWS Lambda Version when referencing functions. When an AWS::Lambda::Version resource is defined in CloudFormation is captures the AWS Lambda configuration *at the time of the creation of the version resource. This means that if the function's configuration or code is updated, the Version resource will no longer point to the function defined in the stack.

To address this, we introduce a property function.currentVersion which will create a new AWS::Lambda::Version resource every time the function's configuration changes. This is done by encoding a hash of the function's CloudFormation properties into the logical ID of the version resource.

Additionally, this change adds version.addAlias which makes it easier to define an AWS Lambda alias for a version.

The result is this:

fn.currentVersion.addAlias('live');

We employ an approach similar to apigateway's "Deployment" resource in order to implement currentVersion: during "prepare", we synthesize the CloudFormation template snippet of the AWS::Lambda::Function resource, calculate an MD5 for it and append it to the logical ID of the version resource.

Resolves #6750
Resolves #5334

End of Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

It is a common use case to define an alias for the latest version of a function. In order to do that, one needs to define a Version resource that points to the latest version and then associate an Alias with it. This was not trivial to do so far. Now it is: fn.addAlias('foo') This will define a lambda.Version with a name the derives from the hash of the lambda's source code and then define a lambda.Alias associated with this version object. Since the name of the version resource is based on the hash, when the code changes, a new version will be created automatically. To support this, `lambda.Code.bind()` now returns an optional `codeHash` attribute. It is supported for `lambda.Code.fromAsset` and `lambda.Code.fromInline`, for which we can calculate the source hash based on the content. Resolves #6750 Resolves #5334

aws-cdk-automation · 2020-03-17T13:58:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 9d6c458
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-lambda/lib/code.ts

packages/@aws-cdk/aws-lambda/lib/function.ts

packages/@aws-cdk/aws-lambda/test/test.code.ts

packages/@aws-cdk/aws-lambda/README.md

skinny85 · 2020-03-17T18:28:27Z

Just wanted to make sure this comment is taken into account in this functionality.

Co-Authored-By: Niranjan Jayakar <nija@amazon.com>

eladb · 2020-03-17T18:58:30Z

Just wanted to make sure this comment is taken into account in this functionality.

Thanks @skinny85. That's really good point. I will see what I can do about it.

aws-cdk-automation · 2020-03-17T19:09:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 4ba3d1f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iph · 2020-03-20T08:41:05Z

Just wanted to make sure this comment is taken into account in this functionality.

Posted a reply there: #5334 (comment)

I'm still for this change, we need to be a bit crafty about it though :)

aws-cdk-automation · 2020-03-23T09:21:26Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: e5b0e25
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-23T09:37:43Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 721f2d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-23T09:39:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: da122b2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-lambda/README.md

packages/@aws-cdk/aws-lambda/lib/function.ts

rix0rrr

Provisional approval

aws-cdk-automation · 2020-03-24T16:09:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: ee2b170
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T16:12:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 629c81c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T16:12:26Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: ac67061
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T16:19:31Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: fe10bdb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T16:20:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: e7bddd1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T16:25:46Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 5c804cd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T17:37:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d240dfd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T18:42:36Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 46366cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-24T19:06:05Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 88787ff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…mpatibility

aws-cdk-automation · 2020-03-25T09:42:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c045300
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-25T09:44:04Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-03-25T09:44:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: fba86fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-25T09:45:31Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 3a06e76
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

README referenced a non-existing property called `function.codeHash`. This comment slipped in from a previous iteration of #6771

iDVB · 2020-05-30T04:44:42Z

Just wanted to make sure this comment is taken into account in this functionality.

Thanks @skinny85. That's really good point. I will see what I can do about it.

Hey @eladb did a resolve for this end up making it in?
I must admit, I'm a bit confused as to where things are right now with this.
I'm using aws-lambda-nodejs and need a way to handle version creations when something changes in the "bundled" versions of the function.

I'm super new to CDK and just poking around, so I added this to a local copy of aws-lambda-nodejs ...

    // Build with Parcel
    const builder = new Builder({
      entry,
      outDir: handlerDir,
      global: handler,
      minify: props.minify,
      sourceMaps: props.sourceMaps,
      cacheDir: props.cacheDir,
      nodeVersion: extractVersion(runtime),
      nodeDockerTag: props.nodeDockerTag || `${process.versions.node}-alpine`,
      projectRoot: path.resolve(projectRoot),
    });
    builder.build();
  
    super(scope, id, {
      ...props,
      runtime,
      code: lambda.Code.fromAsset(handlerDir),
      handler: `index.${handler}`,
    });

    this.shasum = getFileShaSum(`${handlerDir}/index.js`);
  }
}

function getFileShaSum(filePath: string): string {
  const relativePath = path.relative(process.cwd(), filePath);
  const shasum = crypto.createHash('sha256')
  const fileBuffer = fs.readFileSync(relativePath)
  shasum.update(fileBuffer)
  return `:sha256:${shasum.digest('hex')}`;
}

So I can do this in my main file...

    const replicaLambda = new lambda.NodejsFunction(this, 'lambda-handler', {
      minify: true,
      timeout: Duration.seconds(10),
    })
    replicaLambda.addVersion(replicaLambda.shasum)

Reading the above thread and a few other issues, it seems like you guys have gone around the block on where this functionality should live?

Would love to know how off base I am, or a workaround as this is really the last thing stopping us to diving into CDK.

eladb requested a review from nija-at March 17, 2020 13:45

mergify bot added the contribution/core This is a PR that came from AWS. label Mar 17, 2020

eladb mentioned this pull request Mar 17, 2020

aws-lambda: Simplify Lambda provisioned concurrency autoscaling #6400

Closed

1 task

nija-at reviewed Mar 17, 2020

View reviewed changes

Update packages/@aws-cdk/aws-lambda/lib/code.ts

4ba3d1f

Co-Authored-By: Niranjan Jayakar <nija@amazon.com>

SomayaB assigned nija-at Mar 19, 2020

nija-at assigned eladb and unassigned nija-at Mar 19, 2020

Elad Ben-Israel added 2 commits March 22, 2020 16:57

Merge remote-tracking branch 'origin/master' into benisrae/code-hash

363e9a5

change approach to "currentVersion"

e5b0e25

eladb changed the title ~~feat(lambda): add alias to latest version through code hash~~ feat(lambda): currentVersion Mar 23, 2020

eladb changed the title ~~feat(lambda): currentVersion~~ feat(lambda): currentVersion and version.addAlias() Mar 23, 2020

eladb changed the title ~~feat(lambda): currentVersion and version.addAlias()~~ feat(lambda): currentVersion, version.addAlias() Mar 23, 2020

Elad Ben-Israel added 2 commits March 23, 2020 11:26

get rid of codeHash

721f2d7

clean up

da122b2

eladb requested review from nija-at, rix0rrr and skinny85 March 23, 2020 09:28

rix0rrr requested changes Mar 23, 2020

View reviewed changes

packages/@aws-cdk/aws-lambda/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Mar 23, 2020

rix0rrr approved these changes Mar 23, 2020

View reviewed changes

update snapshot

d240dfd

Elad Ben-Israel added 2 commits March 24, 2020 20:20

update ddb snapshot

46366cb

revert location of logGroup

88787ff

Elad Ben-Israel added 3 commits March 25, 2020 10:55

do not sort env vars if "currentVersion" is not used for backwards co…

c045300

…mpatibility

revert newline

3a06e76

Merge branch 'master' into benisrae/code-hash

fba86fd

mergify bot merged commit c94ce62 into master Mar 25, 2020

mergify bot deleted the benisrae/code-hash branch March 25, 2020 09:44

eladb pushed a commit that referenced this pull request Apr 10, 2020

chore(lambda): fix misleading reference to "codeHash" in readme

dd8c945

README referenced a non-existing property called `function.codeHash`. This comment slipped in from a previous iteration of #6771

eladb mentioned this pull request Apr 10, 2020

chore(lambda): fix misleading reference to "codeHash" in readme #7308

Merged

mergify bot pushed a commit that referenced this pull request Apr 10, 2020

chore(lambda): fix misleading reference to "codeHash" in readme

1570d36

README referenced a non-existing property called `function.codeHash`. This comment slipped in from a previous iteration of #6771

NetaNir mentioned this pull request Apr 21, 2020

Calculate CodeSha256 from Lambda code assets for Lambda Versions #7494

Closed

marcogrcr mentioned this pull request Nov 11, 2020

[aws-lambda] Function.prototype.currentVersion does not work with Code.fromCfnParameters #11433

Open

nija-at mentioned this pull request May 5, 2021

[lambda]Incorrect Lambda function version calculation causes deployment difficulty #11537

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): currentVersion, version.addAlias() #6771

feat(lambda): currentVersion, version.addAlias() #6771

eladb commented Mar 17, 2020 •

edited

Loading

aws-cdk-automation commented Mar 17, 2020

skinny85 commented Mar 17, 2020

eladb commented Mar 17, 2020

aws-cdk-automation commented Mar 17, 2020

iph commented Mar 20, 2020

aws-cdk-automation commented Mar 23, 2020

aws-cdk-automation commented Mar 23, 2020

aws-cdk-automation commented Mar 23, 2020

rix0rrr left a comment

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 24, 2020

aws-cdk-automation commented Mar 25, 2020

mergify bot commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

iDVB commented May 30, 2020

feat(lambda): currentVersion, version.addAlias() #6771

feat(lambda): currentVersion, version.addAlias() #6771

Conversation

eladb commented Mar 17, 2020 • edited Loading

Commit Message

End of Commit Message

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

skinny85 commented Mar 17, 2020

eladb commented Mar 17, 2020

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

iph commented Mar 20, 2020

aws-cdk-automation commented Mar 23, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 23, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 23, 2020

AWS CodeBuild CI Report

rix0rrr left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 24, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

mergify bot commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

iDVB commented May 30, 2020

eladb commented Mar 17, 2020 •

edited

Loading