Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): database instance - auto scale allocated storage #6788

Merged
merged 32 commits into from
Mar 24, 2020
Merged

feat(rds): database instance - auto scale allocated storage #6788

merged 32 commits into from
Mar 24, 2020

Conversation

nirvana124
Copy link
Contributor

@nirvana124 nirvana124 commented Mar 18, 2020 •
edited by nija-at
Loading

Commit Message

feat(rds): database instance - auto scale allocated storage (#6788)

fixes #6666

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

pankajy93 and others added 23 commits February 28, 2020 18:08
@pankajy93
fix(apigateway): Allows configuring authorization scopes in apigatewa…
375a157 
…y method fixes#6390
@pankajy93
Fixes build failure for Case sensitive fields
37249b2
@nirvana124
Merge branch 'master' into master
bab8d99
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
71ab433 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
26c31ea 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
14dfbe7 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
4612c83 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
87cbb71 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124
Merge branch 'master' into master
07a3188
@pankajy93
Added test cases to cover auth scopes absent and method options auth …
49d3752 
…scope take the priority in case method options and default options are passed
@pankajy93
Updating readme for authorizationScopes
3399253
@pankajy93
removing trailing white space to fix @aws-cdk/aws-apigateway: ERROR: …
913df38 
…/codebuild/output/src052287507/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-apigateway/lib/method.ts:80:87 - trailing whitespace
@nirvana124
Merge branch 'master' into master
3f451f7
@nirvana124
Merge branch 'master' into master
9b558f4
@pankajy93
adds comments under default integration and method section.
6b3e232
@nirvana124
Merge branch 'master' into master
7518e33
adjust lang in README
5cea74b
@pankajy93
Reolved conflicts
4660a32
@pankajy93
Merge branch 'master' of https://github.com/nirvana124/aws-cdk
c11dc30
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
3f75fca
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
b7b169e 
merge
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
0399ffc
@pankajy93
feat(rds): configure maxAllocatedStorage for rds fixes aws#6666
fcc79bf
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fcc79bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fff58e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously requested changes Mar 23, 2020
View reviewed changes
packages/@aws-cdk/aws-rds/README.md Outdated
Comment on lines 79 to 93

To use the storage auto scaling option of RDS you can specify the maximum allocated storage.
This is the upper limit to which RDS can automatically scale the storage. More info can be found
[here](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html#cfn-rds-dbinstance-maxallocatedstorage)
Example for max storage configuration:
```ts
const instance = new DatabaseInstance(stack, 'Instance', {
engine: rds.DatabaseInstanceEngine.ORACLE_SE1,
instanceClass: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
masterUsername: 'syscdk',
vpc,
maxAllocatedStorage: 200
});
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to line 60 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to 61.

@nija-at nija-at changed the title feat(rds): configure maxAllocatedStorage for rds fixes #6666 feat(rds): database instance - auto scale allocated storage Mar 23, 2020
@nirvana124
spell fix
7b6fb74 
Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
nirvana124 and others added 2 commits March 23, 2020 18:29
@nirvana124
spell fix
84f84b7 
Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
@nirvana124
Adding docs url
7ffd572 
Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review March 23, 2020 13:01

Pull request has been modified.

nirvana124 and others added 2 commits March 23, 2020 18:31
@nirvana124
Correct url of autoscale document
e1e2c23 
Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
@nirvana124
Adding new line
c6e6b4d 
Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7b6fb74
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7ffd572
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 84f84b7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c6e6b4d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e1e2c23
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8253fc2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124 nirvana124 requested a review from nija-at March 24, 2020 06:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: aa0c688
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 928f4c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 22ffae3 into aws:master Mar 24, 2020
@nirvana124 nirvana124 deleted the nirvana124/maxAllocatedStorage branch March 24, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RDS] Support Storage Autoscaling option on Database Instance
4 participants
@nirvana124 @aws-cdk-automation @nija-at @pankajy93