Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Identity Provider - SAML #6853

Closed
1 of 2 tasks
moofish32 opened this issue Mar 19, 2020 · 2 comments
Closed
1 of 2 tasks

User Identity Provider - SAML #6853

moofish32 opened this issue Mar 19, 2020 · 2 comments
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@moofish32
Copy link
Contributor

moofish32 commented Mar 19, 2020

Cognito Identity Providers are not supported as an AWS construct or natively by the User Pool construct. Integrating this new construct with the user pool will resolve challenges correctly setting attribute mutability as warned in the documentation

Use Case

I want to be able to easily integrate a user pool with my company provided SAML IdP. The same will be true for other IdPs supported by Cognito.

Proposed Solution

Correctly model the providers available in the current list. I don't think this is really a stand alone construct, but an integrated function on the user pool. Depending on the variation on the interface this may be require individual methods to avoid JSII limits regarding interface unions.

CDK might look like:

         const userPool: cognito.UserPool = new cognito.UserPool(this, `${id}-pool`, {
            userPoolName: props.name,
            autoVerify: { email: true },
            selfSignUpEnabled: props.allowUserSignUp,
            mfa: cognito.Mfa.OFF,
            requiredAttributes: {
              email: true,
              nickname: true,
              fullname: true,
            },
            lambdaTriggers: { preTokenGeneration: preTokenTrigger },
        });
        userPool.addSamlIdp(mySamlIdpProps); // userPool.addGoogleIdp(myGoogleProps) ...

In that function we will ensure mutable properties from the mapping json are correctly set in the user pool properties. By providing individual functions we'll have type validation.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@moofish32 moofish32 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 19, 2020
@SomayaB SomayaB added the @aws-cdk/aws-cognito Related to Amazon Cognito label Mar 20, 2020
@nija-at nija-at added effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 22, 2020
@nija-at nija-at changed the title Cognito Identity Providers User Identity Provider - SAML Jul 10, 2020
@nija-at nija-at added the p1 label Aug 17, 2020
@TheRealAmazonKendra
Copy link
Contributor

Looks like this has actually been implemented. Closing this issue.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants