Allow specifying runOrder and roleArn for CodePipeline Actions

[lusentis]

Hello,
I was reading #265 and #642 to figure out what's the current support for CodePipeline, CodeBuild etc...

I have understood that:

• There's no support for specifying the RunOrder property. Is there a specific reason? Seems to be supported at a Stage level (https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-codepipeline/lib/stage.ts#L113) but not passed down from the BuildAction, DeployAction classes (https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-codepipeline-api/lib/build-action.ts#L47)

• There's no support for specifying an Action RoleArn, which is essential for Cross-account deployments using a CloudFormation Action. What's missing here is the support for a roleArn property in https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudformation/lib/pipeline-actions.ts. (This RoleArn property is different from the one that we can specify inside the configuration object, which is the CloudFormation Execution Role)

I have some time that I could spend on implementing these two points, as they would be really useful for a SAM project I'm porting to CDK. Let me know if I can help and submit a PR.

Thanks! 🎉

[skinny85]

Hi Simone,

thanks for opening the issue! Yes, we are aware of these shortcomings, and plan to fix both before CDK hits 1.0.

For runOrder, right now, it's actually a public property of each Action - so, you could do something like:

const sourceAction  = new codecommit.PipelineSource(this, 'CodeCommit', {
    stage: sourceStage,
    artifactName: 'Source',
    repository: myCodeCommitRepository,
});
sourceAction.runOrder = 13; // default is 1

However, that's just a temporary stopgap, and long term we will make runOder a property that every Action has. I'll try to submit a PR shortly.

As for the cross-account CodePipelines - we actually have a an issue for general support for cross-account resources (#49). Until we have more info there, we're holding off on supporting the roleArn property of Action. Hopefully, we will be able to come up with a design that will hide a lot of the complexity that's currently involved in creating a cross-account CodePipeline. Stay tuned!

[lusentis]

Great, thanks for the hint on runOrder!
I'll follow #49 then. I'll be the first one to test new suff there 😄