Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codebuild): expose aws/windows/base:2.0 image #7004

Merged
merged 4 commits into from
Mar 25, 2020
Merged

feat(codebuild): expose aws/windows/base:2.0 image #7004

merged 4 commits into from
Mar 25, 2020

Conversation

RomainMuller
Copy link
Contributor

The 1.0 version of this image, while still supported by the service, is
no longer documented on the CodeBuild supported images documentation.
Users are recommended to upgrade to the 2.0 version of the image, which
also comes with up-to-date versions of Node, DotNet SDK, etc...

This PR makes a new WindowsBuildImage.WINDOWS_BASE_2_0 constant
available to easily access this build image, and proceeds to deprecate
the older WindowsBuildImage.WIN_SERVER_CORE_2016_BASE image.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller
feat(codebuild): expose aws/windows/base:2.0 image
c60ce2e 
The 1.0 version of this image, while still supported by the service, is
no longer documented on the CodeBuild supported images documentation.
Users are recommended to upgrade to the 2.0 version of the image, which
also comes with up-to-date versions of Node, DotNet SDK, etc...

This PR makes a new `WindowsBuildImage.WINDOWS_BASE_2_0` constant
available to easily access this build image, and proceeds to deprecate
the older `WindowsBuildImage.WIN_SERVER_CORE_2016_BASE` image.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 25, 2020
@RomainMuller RomainMuller requested a review from skinny85 March 25, 2020 12:09
@RomainMuller RomainMuller added the effort/small Small work item – less than a day of effort label Mar 25, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c60ce2e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5f15938
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks Romain!

@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1ed7a91
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9374642 into master Mar 25, 2020
@mergify mergify bot deleted the rmuller/windows-2.0 branch March 25, 2020 17:27
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 75f4716
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

@nija-at nija-at nija-at approved these changes

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomainMuller @aws-cdk-automation @skinny85 @nija-at