Aspects are not always applied to resource created by Aspects

[NetaNir]

Resource can be created via aspects and they will be added to the construct tree during the invokeAspects phase in prepare. Since aspects are applied to a scope, it is possible that the a resource created via aspect will be created in a scope that has other aspects applied. However, whether these aspects will be invoked on the newly created resource depends on the order of aspects invocation.
An easy example to think of to fully understand the problem are Tags, which are implemented using aspects. Lets say that I want to tag all of the resource in my application with foo:bar:

const root = new App();
root.node.applyAspect(new Tag('foo', 'bar')); //adds the tag to all taggable  resources under root 
const stack = new Stack(root, 'MyStack');
const resourceA = new Construct(stack, 'ResourceA');
// TaggableResource is a resource that can be tagged
new TaggableResource(resource, 'Resource', {
  type: 'AWS::Fake::Thing',
});

Additionally, I would like to apply MyAspect that creates a resource to resourceA:

class MyAspect implements IAspect {
  public visit(node: Construct): void {
    new TaggableResource(node, `${node.node.id}-AspectAdded`, {
      type: 'AWS::Fake::Aspect::Thing:',
    });
  }
}

Apply MyAspect to resourceA:

resourceA.node.applyAspect(new MyAspect());

Since aspects are applied root to leaves, the newly created resource will not be tagged since it was created after the tag aspect has been invoked.

Environment

• CLI Version 1.31 :
• Framework Version: 1.31

Other

---

This is 🐛 Bug Report

[NetaNir]

closed #8639

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.