-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): user pool - OAuth2.0 authentication #7141
Conversation
Support for OAuth2.0 properties in the UserPoolClient construct. BREAKING CHANGES: The type of the `authFlow` property in `UserPoolClient` has changed. This is no longer an enum, but instead a set of fields to toggle. The list has also been updated to reflect the change from `ADMIN_NO_SRP_AUTH` to its newer alias `ADMIN_USER_PASSWORD_AUTH`.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc comments, all in all looks good (though confusing to a newb!)
}); | ||
``` | ||
|
||
Custom authentication protocols can be configured by setting the `custom` property under `authFlow` and defining lambda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda hate that this is implemented on 2 different resources. Do you know what the reason is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming your question is about the CF resources, this is because each user pool client can be configured with different combination of authentication flows, of which 'custom' is one choice. So the 'custom' property is on the client.
If a 'custom' authflow is chosen, the behaviour of the backend is determined by the user via lambda functions. The backend here is represented by the user pool, hence it's configured on the user pool.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Support for OAuth2.0 properties in the UserPoolClient construct. BREAKING CHANGES: The type of the `authFlow` property in `UserPoolClient` has changed. This is no longer an enum, but instead a set of fields to toggle. The list has also been updated to reflect the change from `ADMIN_NO_SRP_AUTH` to its newer alias `ADMIN_USER_PASSWORD_AUTH`.
Commit Message
Support for OAuth2.0 properties in the UserPoolClient construct.
BREAKING CHANGES: The type of the
authFlow
property inUserPoolClient
has changed. This is no longer an enum, but instead aset of fields to toggle. The list has also been updated to reflect the
change from
ADMIN_NO_SRP_AUTH
to its newer aliasADMIN_USER_PASSWORD_AUTH
.End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license