Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable A record creation in ECS patterns for private LBs #7206

Closed
hencrice opened this issue Apr 6, 2020 · 3 comments
Closed
Assignees
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/pattern Feature requests related to high level L3 pattern libraries feature-request A feature should be added or improved. needs-design This feature request needs additional design work. p2

Comments

@hencrice
Copy link
Contributor

hencrice commented Apr 6, 2020

Give customers an option to disable A record creation in ECS pattern when the load balancers are private.

Use Case

Some customers may not want an A record to be created when their ECS/Fargate services are behind private load balancer.

Proposed Solution

Our initial attempt was: #6895, which straight out disabled A record creation whenever the load balancer is private. However, turned out that multiple customers actually rely on such a behavior:

To satisfy both groups of customers, we can potentially add a new boolean flag to all the following interfaces:

The flag can be named as createARecord with default value true to be backward-compatible.

Other

Customer ask: #6702
Initial incorrect attempt: #6895

Please +1 if you would like to see this feature implemented!

This is a 🚀 Feature Request

@hencrice hencrice added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. @aws-cdk/aws-ecs-patterns Related to ecs-patterns library p2 labels Apr 6, 2020
@hencrice
Copy link
Contributor Author

hencrice commented Apr 6, 2020

Temporarily close this until we finalize the wording

@hencrice hencrice closed this as completed Apr 6, 2020
@hencrice hencrice reopened this Apr 6, 2020
@SomayaB SomayaB added needs-design This feature request needs additional design work. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 6, 2020
@konstantinj
Copy link

I think this is not a good idea. If you don't want the behaviour ECS patterns is producing simply you the bare ECS classes instead. There are more behaviours that could be controlled in ECS patterns - it's nonsense to make all of them configurable. For most customers the ECS patterns are just fine as they are.

@ericzbeard ericzbeard added the feature/pattern Feature requests related to high level L3 pattern libraries label Apr 2, 2021
@MrArnoldPalmer MrArnoldPalmer added the effort/small Small work item – less than a day of effort label May 17, 2021
@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 21, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/pattern Feature requests related to high level L3 pattern libraries feature-request A feature should be added or improved. needs-design This feature request needs additional design work. p2
Projects
None yet
Development

No branches or pull requests

6 participants