fix: new IAM Condition type is unusable in Java #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changing of the type of `Condition` from `any` to `Record<string, any>` broke common code in Java. Many users would be passing a `Map<String, String>` in that location, which WOULD be assignable to the old type `Object`, but not to the new type `Map<String, Object>`. Revert for now and turn this into a feature request to jsii team.
NetaNir
approved these changes
Apr 9, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
added a commit
that referenced
this pull request
Apr 9, 2020
The changing of the type of `Condition` from `any` to `Record<string, any>` broke common code in Java. Many users would be passing a `Map<String, String>` in that location, which WOULD be assignable to the old type `Object`, but not to the new type `Map<String, Object>`. Revert for now and turn this into a feature request to jsii team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
The changing of the type of
ConditionfromanytoRecord<string, any>broke common code in Java.Many users would be passing a
Map<String, String>in that location,which WOULD be assignable to the old type
Object, but not to thenew type
Map<String, Object>.Revert for now and turn this into a feature request to jsii team.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license