Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(efs): drop Efs prefix from all exported types #7481

Merged
merged 6 commits into from
Apr 23, 2020
Merged

chore(efs): drop Efs prefix from all exported types #7481

merged 6 commits into from
Apr 23, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Apr 21, 2020 •
edited
Loading

Commit Message

chore(efs): drop Efs prefix from all exported types (#7481)

  • Drop the Efs prefix to the exported types.
  • Change the type of provisioned throughput property to use Size.

BREAKING CHANGE: Exported types no longer have the Efs prefix.

  • efs: provisionedThroughputInMibps property is renamed to
    provisionedThroughputPerSecond and has the type Size.
  • efs: The property fileSystemID is now renamed to
    fileSystemId in the now named FileSystemAttributes (previously,
    EfsFileSystemAttributes).
  • efs: LifecyclePolicyProperty is now renamed to
    LifecyclePolicy.

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(efs): align construct library to latest standards
29dcb0a 
- Drop the `Efs` prefix to the exported types.
- Change the type of provisioned throughput property to use `Size`.

BREAKING CHANGE: Exported types no longer have the `Efs` prefix.
* **efs:** `provisionedThroughputInMibps` property is renamed to
`provisionedThroughputInSeconds` and has the type `Size`.
@nija-at nija-at self-assigned this Apr 21, 2020
@nija-at nija-at requested review from rix0rrr and a team April 21, 2020 14:53
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 21, 2020
@nija-at nija-at changed the title chore(efs): align construct library to latest standards chore(efs): drop Efs prefix for all exported types Apr 21, 2020
@nija-at nija-at changed the title chore(efs): drop Efs prefix for all exported types chore(efs): drop Efs prefix from all exported types Apr 21, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 29dcb0a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously requested changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your BREAKING CHANGE entry mentions provisionedThroughputInSeconds which made me wonder why it wasn't a Duration....

but you actually meant provisionedThroughputPerSecond

rix0rrr
rix0rrr previously requested changes Apr 22, 2020
View reviewed changes
@nija-at
Copy link
Contributor Author

nija-at commented Apr 22, 2020

your BREAKING CHANGE entry mentions provisionedThroughputInSeconds which made me wonder why it wasn't a Duration....

but you actually meant provisionedThroughputPerSecond

Good catch. Thanks!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a1f860a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at requested review from rix0rrr and shivlaks April 22, 2020 08:56
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8de434a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8696520
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at dismissed stale reviews from rix0rrr and shivlaks April 22, 2020 14:22

feedback addressed

@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Apr 23, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bd832d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Apr 23, 2020
View reviewed changes
packages/@aws-cdk/aws-efs/lib/efs-file-system.ts

// tslint:disable: max-line-length
// tslint:disable:max-line-length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. link 2 lines below exceeds our 150 line width.

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Apr 23, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 90f7906
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ddd47cd into master Apr 23, 2020
@mergify mergify bot deleted the nija-at/efs-cleanup branch April 23, 2020 08:55
jogold added a commit to jogold/aws-cdk that referenced this pull request Apr 23, 2020
@jogold
EfsFileSystem -> FileSystem after aws#7481
8eef8a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@shivlaks shivlaks shivlaks approved these changes

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nija-at @aws-cdk-automation @rix0rrr @eladb @shivlaks