fix(route53): cannot add tags to HostedZone
#7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't classify `HostedZoneTags` as the tagging property
since it follows a naming convention where it's not called `Tags`.
`HostedZoneTags` are also an array of type `HostedZoneTag` objects that
enforce the `{Key: "...", Value: "..."}` convention.
This is similar to `FileSystemTags` property for `EFS`
Closes #7445
shivlaks
changed the title
HostedZoneHostedZone
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Apr 23, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
fix(route53): cannot add tags to
HostedZone(#7531)We don't classify
HostedZoneTagsas the tagging propertysince it follows a naming convention where it's not called
Tags.HostedZoneTagsare also an array of typeHostedZoneTagobjects thatenforce the
{Key: "...", Value: "..."}convention.This is similar to
FileSystemTagsproperty forEFSCloses #7445
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license