Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): test invoke option is not recognized #7604

Closed
wants to merge 1 commit into from
Closed

fix(apigateway): test invoke option is not recognized #7604

wants to merge 1 commit into from

Conversation

rigsbyt
Copy link

@rigsbyt rigsbyt commented Apr 24, 2020 •
edited by nija-at
Loading

Specifying options.allowTestInvoke = true will cause enableTest to get set to false, since it is not undefined. Default to allowTestInvoke if it was not undefined.

Commit Message

fix(aws-apigateway): test invoke option is not recognized (#7604)

fixes #7605

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rigsbyt
Properly handle options.allowTestInvoke = true
81a521a 
Specifying options.allowTestInvoke = true will cause enableTest to get set to false, since it is not undefined. Default to allowTestInvoke if it was not undefined.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 81a521a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@rigsbyt rigsbyt changed the title Properly handle options.allowTestInvoke = true fix: Properly handle options.allowTestInvoke = true Apr 24, 2020
@rigsbyt rigsbyt changed the title fix: Properly handle options.allowTestInvoke = true fix(aws-apigateway): properly handle options.allowTestInvoke = true Apr 24, 2020
@rigsbyt rigsbyt mentioned this pull request Apr 24, 2020
Closed
@rigsbyt
Copy link
Author

rigsbyt commented Apr 24, 2020

Issue: #7605

@nija-at nija-at changed the title fix(aws-apigateway): properly handle options.allowTestInvoke = true fix(apigateway): test invoke option is not recognized Apr 30, 2020
nija-at
nija-at suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR!

Could you add a corresponding unit test?

@nija-at nija-at added closing-soon This issue will automatically close in 4 days unless further comments are made. effort/small Small work item – less than a day of effort labels Jun 3, 2020
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 4, 2020
@github-actions github-actions bot closed this Jun 4, 2020
@wtho wtho mentioned this pull request Oct 12, 2020
Merged
mergify bot pushed a commit that referenced this pull request Oct 16, 2020
@wtho
fix(apigateway): lambda integration does not recognize allowTestInvoke (
650c23f 
#10828)

Fixes the issue of handling `allowTestInvoke: true` like `allowTestInovke: false` in `LambdaIntegration`.

fixes #7605
related: #7604


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at requested changes

Assignees

@nija-at nija-at

Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api gateway lambda integration incorrectly handles allowTestInvoke
3 participants
@rigsbyt @aws-cdk-automation @nija-at