Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk-assets): assets archiving corruption #7653

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Apr 28, 2020

Commit Message

fix(cdk-assets): assets archiving corruption (#7653)

Asset archiving did not register the callbacks correctly.

The close event was only registered after calling finalize, which may cause the promise to be resolved before the stream was actually closed.

From the documentation of the archiver package:

// finalize the archive (ie we are done appending files but streams have to finish yet)
// 'close', 'end' or 'finish' may be fired right after calling this method so register to them beforehand
archive.finalize();

Fixes #6925

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 28, 2020
@iliapolo iliapolo added the pr-linter/exempt-test The PR linter will not require test changes label Apr 28, 2020
@iliapolo iliapolo requested a review from a team April 28, 2020 20:26
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the root cause in the commit message itself. I think it makes sense to move the details from the PR description to the commit message.

@iliapolo iliapolo force-pushed the epolon/fix-sporadic-asset-corruption branch from 21c4879 to 4343a1f Compare April 28, 2020 20:40
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fa61e22
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 21c4879
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f8eddb8 into master Apr 28, 2020
@mergify mergify bot deleted the epolon/fix-sporadic-asset-corruption branch April 28, 2020 21:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4343a1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors using ZipFile in the BucketDeployment Construct
4 participants