fix(eks): ssm path for gpu optimized ami is invalid #7672
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
copy @eladb |
eladb
changed the title
| this.nodeType = props && props.nodeType; | ||
| this.kubernetesVersion = props && props.kubernetesVersion || LATEST_KUBERNETES_VERSION; | ||
| public constructor(props: EksOptimizedImageProps = { }) { | ||
| this.nodeType = props.nodeType ?? NodeType.STANDARD; |
There was a problem hiding this comment.
Sure! One more thing - as the default cluster creation now goes to 1.15 as the default k8s version. Are we going to change LATEST_KUBERNETES_VERSION to 1.15 or just keep it as is(1.14)? @eladb
aws-cdk/packages/@aws-cdk/aws-eks/lib/cluster.ts
Lines 1018 to 1019 in 307c8b0
I am afraid changing it to 1.15 will force the work node upgrade though.
There was a problem hiding this comment.
I was running the integ testing.
Now as the default version goes to 1.15, the managed nodegroup AMI goes to 1.15
AMI ID amazon-eks-node-1.15-v20200228 (ami-06abd5347585f6519)
and the self-managed AMI will goes to 1.14 because of the LATEST_KUBERNETES_VERSION
AMI ID amazon-eks-node-1.14-v20200423 (ami-0bc4f8babcbafed56)
There was a problem hiding this comment.
I think we should not offer a default Kubernetes version and require that version always be explicitly set. The current behavior is not sustainable
Let’s do it in a separate PR though.
eladb
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Commit Message
fix(eks): ssm path for amazon linux 2 gpu ami is invalid (#7672)
According to the document, the path should be /aws/service/eks/optimized-ami/1.15/amazon-linux-2/recommended/image_id
Also fixes #6891
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license