Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add condition to aws_sns_subscriptions #7845

Open
1 of 2 tasks
snorberhuis opened this issue May 7, 2020 · 3 comments
Open
1 of 2 tasks

Cannot add condition to aws_sns_subscriptions #7845

snorberhuis opened this issue May 7, 2020 · 3 comments
Labels
@aws-cdk/aws-sns-subscriptions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@snorberhuis
Copy link

I would like to be able to add conditions to subscriptions.

Use Case

The use case here is that we want to add subscriptions only on some environments. For example, I want to add SMS subscriptions to an alarm topic only on productiolike environments.

Proposed Solution

subscription = aws_sns_subscriptions.LambdaSubscription(function)
subscription.bind(topic)
subscription.node.default_child.cfn_options.condition = condition

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@snorberhuis snorberhuis added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2020
@MrArnoldPalmer MrArnoldPalmer added effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 15, 2020
@MrArnoldPalmer
Copy link
Contributor

This looks similar to #8396, in that you can't currently pass any "CFN yielding" expression to Fn.conditionIf. I'm not exactly sure if that fix will also enable this though will have to investigate further.l

@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 21, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 21, 2022
@snorberhuis
Copy link
Author

I still think this should be a feature for sns_subscriptions.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 22, 2022
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sns-subscriptions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants