fix(codepipeline): allow multiple CodeCommit source actions using events #8018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@rix0rrr ping |
rix0rrr
approved these changes
May 29, 2020
packages/@aws-cdk/aws-codepipeline-actions/lib/codecommit/source-action.ts
Outdated
Show resolved
Hide resolved
skinny85
force-pushed
the
fix/codecommit-source-action-duplicate-events
branch
from
171f445 to
2183792
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There are use-cases when you want to add the same CodeCommit repository to a CodePipeline multiple times, with different branches. This wouldn't work when using CloudWatch Events to trigger the pipeline, as the ID of the generated Event only used the pipeline ID for uniqueness. Change it to also use the branch name when generating the Event ID (which cannot be empty, as it turns out, so validate that as well). Fixes aws#7802
skinny85
force-pushed
the
fix/codecommit-source-action-duplicate-events
branch
from
2183792 to
ec644ec
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use-cases when you want to add the same CodeCommit
repository to a CodePipeline multiple times, with different branches.
This wouldn't work when using CloudWatch Events to trigger the pipeline,
as the ID of the generated Event only used the pipeline ID for uniqueness.
Change it to also use the branch name when generating the Event ID
(which cannot be empty, as it turns out, so validate that as well).
Fixes #7802
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license