feat(codepipeline): use a special bootstrapless synthesizer for cross-region support Stacks

[skinny85]

Fixes #8082

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[skinny85]

Hey Rico,

this is a draft of the solution to #8082 . I'm putting it as a draft, as I have 2 remaining questions:

1. Does this approach make sense? I'm not sure this example asset declaration (for the template upload location):

{
  "version": "0.0.0",
  "files": {
    "4a751a2697187d165e0f7e6be2e8b8ae26fd67588a03cc3d88b673618201c552": {
      "source": {
        "path": "CrossRegionAndAccountCfnPipelineStack-support-eu-central-1.template.json",
        "packaging": "file"
      },
      "destinations": {
        "828671620168-eu-central-1": {
          "bucketName": "cdk-hnb659fds-assets-828671620168-us-west-2",
          "objectKey": "4a751a2697187d165e0f7e6be2e8b8ae26fd67588a03cc3d88b673618201c552",
          "region": "eu-central-1",
          "assumeRoleArn": "arn:${AWS::Partition}:iam::828671620168:role/cdk-hnb659fds-publishing-role-828671620168-us-west-2"
        }
      }
    }
  },
  "dockerImages": {}
}

is correct (the bucket is cdk-hnb659fds-assets-828671620168-us-west-2, obviously in us-west-2, but the region is eu-central-1, so not sure this works...)

2. Do we have any existing tests that are checking the contents of the generated Cloud Assembly, that I could base the unit tests for this one? Not sure how to test this...

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 50d903f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[rix0rrr]

In fact I think a custom subclass might make more sense. For example, this stack needs to be deployable without a bucket in the target location (as you already noted), so it definitely can't support assets.

So I'm thinking of a subclass that'll throw when addFileAsset or addDockerAsset are called.

I did write that in the original ticket, though only in passing:

We need a new Synthesizer which [...] won't support assets...

Not supporting assets also means that is should also not "upload its own template" the way the default synthesizer does. It can be like the legacy synthesizer in that way, and basically not do anything special there -- the CLI will ultimately deploy the template.

Another restriction we could encode into the synthesizer is, since we know it needs to be deployable without a bootstrap environment, the template itself needs to be <40k (or whatever the size limit is again), so that it goes into one CFN call.

Maybe the specific subclass needs to be a BootstraplessSynthesizer, that could live in core?

[rix0rrr]

Tests around this are here:

https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/core/test/stack-synthesis/test.new-style-synthesis.ts

[rix0rrr]

See el above-o

[skinny85]

That's exactly why I wanted to post this quickly as a draft, this is great Rico!

I'm not sure about this part though:

Maybe the specific subclass needs to be a BootstraplessSynthesizer, that could live in core?

I wonder why you want to put it in core - why not in the codepipeline package?

[skinny85]

@rix0rrr submitted a new version. The result that I now see (with my manual test) is:

    "CrossRegionAndAccountCfnPipelineStack-support-eu-central-1": {
      "type": "aws:cloudformation:stack",
      "environment": "aws://828671620168/eu-central-1",
      "properties": {
        "templateFile": "CrossRegionAndAccountCfnPipelineStack-support-eu-central-1.template.json",
        "assumeRoleArn": "arn:${AWS::Partition}:iam::828671620168:role/cdk-hnb659fds-deploy-role-828671620168-us-west-2",
        "cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::828671620168:role/cdk-hnb659fds-cfn-exec-role-828671620168-us-west-2",
        "requiresBootstrapStackVersion": 1
      },
    },

And there is no CrossRegionAndAccountCfnPipelineStack-support-eu-central-1.assets anymore.

Let me know if this version makes sense, and if "yes", I'll add unit tests for it.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 4eb2637
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[rix0rrr]

Let me know if this version makes sense, and if "yes", I'll add unit tests for it.

Yep, I believe that looks good.

[rix0rrr]

Probably worth doing a size check on the template here as well.

[skinny85]

Can we do it as a quick follow-up to this issue? <bats eyelashes>

[rix0rrr]

Using a ? is the more usual way we express that.

[skinny85]

Yes, but I actually wanted to make the synthesizer a required property.

I don't think it matters much, this is all private to the codepipeline module anyway.

[skinny85]

@rix0rrr included your comments, and added a unit test. This is now ready to graduate from a draft PR.

Let me know if you have any more comments!

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 0c3c530
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[rix0rrr]

I think make these optional and you've got yourself an approved!

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 7040340
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 2a2834b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).