feat(stepfunctions-tasks): task state construct to submit a job to AWS Batch #8115
Conversation
replacement for the current implementation of `RunBatchJob` where service integration and state level properties are merged. Follows the new integration pattern. Notable differences from the `RunBatchJob` implementation: * `payload` prop is now of type `sfn.TaskInput` Rationale: old implementation precluded using task input as the payload directly. Added a test for this as well. * `timeout` in the old implementation has been renamed to `attemptDuration` Rationale: old implementation was really configuring the sub-property named `AttemptDurationSeconds` and precluded the ability to set a timeout on the task itself. Updated the README. Note that the other unit tests and integ test have been left verbatim. This is a light sanity test that expected templates have not changed.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
packages/@aws-cdk/aws-stepfunctions-tasks/lib/batch/submit-job.ts
Outdated
Show resolved
Hide resolved
| * | ||
| * @deprecated use `BatchSubmitJob` |
There was a problem hiding this comment.
Can we reduce the duplication on this implementaion? Can RunBatchJob call BatchSubmitJob?
There was a problem hiding this comment.
similar comment to the one I made for Step Functions. I don't think it's as simple as a straight up swap.
I do agree, there's probably room for some refactoring. I did not try to do it all in this PR though.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
replacement for the current implementation of
RunBatchJobwhereservice integration and state level properties are merged.
Follows the new integration pattern. Notable differences from the
RunBatchJobimplementation:payloadprop is now of typesfn.TaskInputRationale: old implementation precluded using task input as the
payload directly. Added a test for this as well.
Updated the README.
Note that the other unit tests and integ test have been left verbatim. This
is a light sanity test that expected templates have not changed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license