Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-nodejs): allow passing env vars to container #8169

Merged
merged 5 commits into from
Jun 1, 2020
Merged

feat(lambda-nodejs): allow passing env vars to container #8169

merged 5 commits into from
Jun 1, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 23, 2020 •
edited
Loading

Add a containerEnvironment prop to pass environment variables to the
container running Parcel.

Closes #8031

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
feat(lambda-nodejs): allow passing env vars to container
25c19bd 
Add a `containerEnvironment` prop to pass environment variables to the
container running Parcel.

Closes aws#7912
Closes aws#8031
@jogold
Copy link
Contributor Author

jogold commented May 23, 2020

@eladb lambda-nodejs needs a refactor after #7898 but this will already "unblock" some users with issues after we switched to Docker.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 25c19bd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: eaffda4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@blimmer blimmer mentioned this pull request May 26, 2020
Closed
eladb
eladb reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jogold this is expected to change when we introduce bundling, correct? Should we wait for that?

@jogold
Copy link
Contributor Author

jogold commented May 27, 2020

@jogold this is expected to change when we introduce bundling, correct? Should we wait for that?

Correct but releasing this will already "unblock" some users. Your call...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fb369ee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8486eef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 36a2137
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1755cf2 into aws:master Jun 1, 2020
@jogold jogold deleted the lambda-nodejs-env branch June 1, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodejsFunction packages dependencies incorrectly
3 participants
@jogold @aws-cdk-automation @eladb