fix(apigateway): permission error in lambda integration when function name is modified #8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name is modified Changing function name triggers a resource replacement - the old function is removed and replaced with a new function. However, the RestApi deployment remains untouched and is still pointing at the ARN of the, now stale, function. The fix is to trigger a new deployment if the function name changes. fixes #5306
nija-at
added
the
pr-linter/exempt-test
nija-at
pushed a commit
that referenced
this pull request
Jun 30, 2020
Currently, the Method construct reaches into the internals of the Integration class to construct itself, via the _props() internal method. Change to a more recent pattern where the bind() returns a result that contains all of the information that the Method class requires to finalize the bind. Motivation for the change This change - #8813 - requires a property returned to the Method that is not user specified. The change already introduces this pattern. This PR takes it a bit further and applies the same logic to existing properties, so that there is now only one way for the Method to get the result of the bind.
eladb
suggested changes
Jun 30, 2020
nija-at
removed
the
pr-linter/exempt-test
eladb
reviewed
Jun 30, 2020
| * This value is included in computing the Deployment's fingerprint. When the fingerprint | ||
| * changes a new deployment is triggered. | ||
| * This property should carry a different value when the Deployment needs to be refreshed. | ||
| * @default - deployments are not triggered for any change of this integration. |
There was a problem hiding this comment.
Add a note that it can be an arbitrary string and does not have to be a hash.
There was a problem hiding this comment.
Switched to index type <string, string> so the user doesn't have to do JSON.stringify() unless they're adding a nested struct. The input to the hash gen will also be a bit nicer without the serialized objects.
eladb
suggested changes
Jul 1, 2020
eladb
reviewed
Jul 1, 2020
eladb
approved these changes
Jul 1, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
approved these changes
Jul 1, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2020
Currently, the Method construct reaches into the internals of the Integration class to construct itself, via the _props() internal method. Change to a more recent pattern where the bind() returns a result that contains all of the information that the Method class requires to finalize the bind. Motivation for the change This change - #8813 - requires a property returned to the Method that is not user specified. The change already introduces this pattern. This PR takes it a bit further and applies the same logic to existing properties, so that there is now only one way for the Method to get the result of the bind. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing function name triggers a resource replacement - the old
function is removed and replaced with a new function.
However, the RestApi deployment remains untouched and is still pointing
at the ARN of the, now stale, function.
The fix is to trigger a new deployment if the function name changes.
fixes #5306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license