feat(autoscaling): allow setting autoscaling group name #8853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Jul 2, 2020
eladb
suggested changes
Jul 5, 2020
| @@ -596,7 +607,7 @@ export class AutoScalingGroup extends AutoScalingGroupBase implements | |||
|
|
|||
| this.autoScalingGroup = new CfnAutoScalingGroup(this, 'ASG', asgProps); | |||
| this.osType = imageConfig.osType; | |||
| this.autoScalingGroupName = this.autoScalingGroup.ref; | |||
| this.autoScalingGroupName = Token.isUnresolved(this.physicalName) ? this.autoScalingGroup.ref : this.physicalName; | |||
There was a problem hiding this comment.
#We usually always return the ref in this case because when it’s used in the template it also encodes the implicit dependency. If we just return the concrete string, there won’t be an implicit dependency
There was a problem hiding this comment.
What about the cross region referencing case? is this only true for resources who's id is the resource name?
There was a problem hiding this comment.
You need to use this.getResourceName and getResourceArn to obtain a polymorphic token for the name.
See other examples like s3 buckets.
eladb
suggested changes
Jul 7, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thanks for this! 🙇🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting autoscaling group name.
And also shimgrate (shim migration) autoscaling module to jest - thanks @rix0rrr <3
closes #5593
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license