Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): incorrect enableDockerBridge value when enabled #8895

Merged
merged 4 commits into from
Jul 5, 2020
Merged

fix(eks): incorrect enableDockerBridge value when enabled #8895

merged 4 commits into from
Jul 5, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jul 3, 2020

When enableDockerBridge is enabled in BootstrapOptions, pass the value correctly to user-data.

Fixes: #5786


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pahud
Copy link
Contributor Author

pahud commented Jul 3, 2020

Hi @RicoToothless

From the unit test output, I can confirm the --enable-docker-bridge true should be correctly set in the user-data.

And I can successfully kubectl get no to list the nodes with my CDK like this

    // create the cluster with a default nodegroup capacity
    const cluster = new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      defaultCapacity: 0,
      version: eks.KubernetesVersion.V1_16,
    });

    cluster.addCapacity('NG', {
      instanceType: new ec2.InstanceType('t3.large'),
      bootstrapOptions: {
        enableDockerBridge: true,
      }
    });

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6628f2a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud
Copy link
Contributor Author

pahud commented Jul 4, 2020

Hi @eladb ,

PR is ready :-)

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ea0552a into aws:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] BootstrapOptions enable_docker_bridge not working
3 participants