Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): asset bundling fails with BuildKit #8911

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

elthrasher
Copy link
Contributor

@elthrasher elthrasher commented Jul 6, 2020

Docker buildkit has different output from the legacy builder unless you pass the -q flag in which case the output is always just the image tag. This PR works for both build versions.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@elthrasher elthrasher changed the title fix(core) docker-buildkit fix(core): docker-buildkit Jul 6, 2020
Copy link
Contributor

@jogold jogold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladb LGTM - fix(core): asset bundling fails with BuildKit

@eladb eladb changed the title fix(core): docker-buildkit fix(core): asset bundling fails with BuildKit Jul 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4b1a2ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c1d4e0f into aws:master Jul 6, 2020
@elthrasher elthrasher deleted the docker-buildkit branch July 6, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants