Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Python sample app template does not follow PEP8 #8936

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

ojongerius
Copy link
Contributor

@ojongerius ojongerius commented Jul 8, 2020

Classes should be surrounded by 2 blank lines according to PEP8

related PR: aws-samples/aws-cdk-intro-workshop#142


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ojongerius ojongerius changed the title Python class in sample app template should have two leading blank lines fix(cli) class in sample app template should have two leading blank lines Jul 8, 2020
@ojongerius ojongerius changed the title fix(cli) class in sample app template should have two leading blank lines fix(cli): class in sample app template should have two leading blank lines Jul 8, 2020
@shivlaks shivlaks self-assigned this Jul 8, 2020
@shivlaks shivlaks added package/tools Related to AWS CDK Tools or CLI feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md effort/small Small work item – less than a day of effort labels Jul 8, 2020
@shivlaks shivlaks changed the title fix(cli): class in sample app template should have two leading blank lines fix(cli): Python sample app template does not follow PEP8 Jul 8, 2020
@shivlaks shivlaks added the pr-linter/exempt-test The PR linter will not require test changes label Jul 8, 2020
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojongerius thanks for taking the time to submit a PR to fix this in our init templates!!!

I've added the prlinter-exempt-test label as I don't believe this change requires an added test.

Note that I've re-titled the issue to include the current problem. The reason we format our messages in this way is because the commit title will show up in our CHANGELOG and we want users to easily be able to identify the issue that was fixed.

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f3b6019
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0717919 into aws:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants