-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Python sample app template does not follow PEP8 #8936
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojongerius thanks for taking the time to submit a PR to fix this in our init templates!!!
I've added the prlinter-exempt-test
label as I don't believe this change requires an added test.
Note that I've re-titled the issue to include the current problem. The reason we format our messages in this way is because the commit title will show up in our CHANGELOG and we want users to easily be able to identify the issue that was fixed.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Classes should be surrounded by 2 blank lines according to PEP8
related PR: aws-samples/aws-cdk-intro-workshop#142
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license