feat(s3): Introduce S3 Inventory #9102
Conversation
iliapolo
added
response-requested
|
@iliapolo any updates? |
|
@arnulfojr Sorry, haven't forgotten. I'll get to it shortly. |
| ] | ||
| }); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Lets also document the necessary policy document that the destination bucket should have. Something like:
Permissions
If the destination bucket is created as part of the same CDK application, The necessary permissions will be automatically added to the bucket policy. However, if you use an imported bucket (i.e Bucket.fromXXX()), you'll have to make sure it contains the following policy document:
<POLICY_HERE>There was a problem hiding this comment.
Would it be better to add a link to the official documentation rather than adding a sample policy? or both?
There was a problem hiding this comment.
Documentation link would suffice
iliapolo
changed the title
|
@arnulfojr Looks great - thanks! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Resolves aws#8154 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Resolves #8154
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license