feat(ecs): Option to encrypt lifecycle hook SNS Topic #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Posting in draft form to get initial feedback on the API changes. |
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
SomayaB
added
@aws-cdk/aws-ecs
ddneilson
force-pushed
the
ecs_drain_sns_encryption
branch
from
2335767 to
0943ac0
Compare
ddneilson
changed the title
ddneilson
force-pushed
the
ecs_drain_sns_encryption
branch
from
0943ac0 to
f87497a
Compare
|
@SomayaB This is ready to review, and can have the pr/work-in-progress label removed |
SomayaB
removed
the
pr/work-in-progress
bvtujo
approved these changes
Aug 11, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #9230
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license