Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudwatch): alarm status widget #9456

Merged
merged 4 commits into from
Aug 11, 2020
Merged

feat(cloudwatch): alarm status widget #9456

merged 4 commits into from
Aug 11, 2020

Conversation

curtiseppel
Copy link

Add support for the alarm status widget. This widget allows you to see the status of multiple alarms in a grid view.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@curtiseppel curtiseppel force-pushed the cloudwatch/alarm-widget branch from 5453d16 to 2db88dc Compare August 5, 2020 13:11
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 10, 2020

I don't see this alarm type mentioned here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html

Is there a reference for it?

rix0rrr
rix0rrr previously requested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean enough. One typing change, maybe a reference, and then we should be gtg I think.

@curtiseppel curtiseppel force-pushed the cloudwatch/alarm-widget branch 2 times, most recently from 096d013 to bf2e86c Compare August 11, 2020 02:01
@mergify mergify bot dismissed rix0rrr’s stale review August 11, 2020 02:01

Pull request has been modified.

@curtiseppel curtiseppel force-pushed the cloudwatch/alarm-widget branch from bf2e86c to 3ba8811 Compare August 11, 2020 02:02
@curtiseppel
Copy link
Author

curtiseppel commented Aug 11, 2020 •
edited
Loading

I don't see this alarm type mentioned here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html

Is there a reference for it?

The only reference to the Alarm Status widget that I could find is this piece of documentation - https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/add_remove_alarm_dashboard.html

@curtiseppel curtiseppel force-pushed the cloudwatch/alarm-widget branch from 3ba8811 to 2fe682e Compare August 11, 2020 02:03
@curtiseppel curtiseppel requested a review from rix0rrr August 11, 2020 02:04
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2fe682e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 41940d3 into aws:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtiseppel @rix0rrr @aws-cdk-automation