fix(cfn-include): no longer concatenate elements of Fn::Join without tokens #9476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tokens Fn.join() has some logic inside of it to simplify the expressions to concatenate the array elements that do not contain any Tokens inside of them. We don't want to do it in cfn-include though, as that causes a diff from the original template. So, wrap the array given as the second argument to Fn::Join into a Token, to prevent the concatenation logic from triggering.
comcalvi
approved these changes
Aug 6, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
pushed a commit
that referenced
this pull request
Aug 10, 2020
…tokens (#9476) Fn.join() has some logic inside of it to simplify the expressions to concatenate the array elements that do not contain any Tokens inside of them. We don't want to do it in cfn-include though, as that causes a diff from the original template. So, wrap the array given as the second argument to Fn::Join into a Token, to prevent the concatenation logic from triggering. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fn.join() has some logic inside of it to simplify the expressions to concatenate the
array elements that do not contain any Tokens inside of them.
We don't want to do it in cfn-include though,
as that causes a diff from the original template.
So, wrap the array given as the second argument to Fn::Join into a Token,
to prevent the concatenation logic from triggering.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license