Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipelines): add PolicyStatements to CodeBuild project role #9527

Merged
merged 11 commits into from
Aug 18, 2020
Merged

feat(pipelines): add PolicyStatements to CodeBuild project role #9527

merged 11 commits into from
Aug 18, 2020

Conversation

luisantonioa
Copy link
Contributor

Fixes #9163

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

rix0rrr
rix0rrr previously approved these changes Aug 10, 2020
View reviewed changes
@rix0rrr rix0rrr changed the title feat(pipelines): allow adding policystatements to codebuild project role feat(pipelines): add PolicyStatements to CodeBuild project role Aug 10, 2020
@mergify mergify bot dismissed rix0rrr’s stale review August 10, 2020 17:21

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Aug 13, 2020
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review August 13, 2020 16:03

Pull request has been modified.

@srethira
Copy link

Any update on this issue?

@luisantonioa
Copy link
Contributor Author

Any update on this issue?

It has been approved.. but then is out of date. I click Update branch and then it needs an approval again.. and the cycle continues :(

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 18, 2020

The problem it's not merging is not because it's out of date. It's because the build is failing.

rix0rrr
rix0rrr previously approved these changes Aug 18, 2020
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review August 18, 2020 08:51

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a047d5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c570d9c into aws:master Aug 18, 2020
@luisantonioa
Copy link
Contributor Author

The problem it's not merging is not because it's out of date. It's because the build is failing.

I couldn't tell why it was failing. Thanks for the fix and the merge. I wish I had more time to have sorted it out earlier, but was confused by the 2 previous approvals.

@luisantonioa
Copy link
Contributor Author

I copied the test from: https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/pipelines/test/builds.test.ts#L14

Should that test have the same change applied?

misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this pull request Aug 19, 2020
@luisantonioa @misterjoshua
feat(pipelines): add PolicyStatements to CodeBuild project role (aws#…
7732691 
…9527)

Fixes aws#9163


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@luisantonioa luisantonioa deleted the luisantonioa/cdk-pipelines-simplesynthaction-9163 branch August 19, 2020 18:25
@erudisch erudisch mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cdk-pipelines] SimpleSynthAction unable to set role or add policies to it.
4 participants
@luisantonioa @srethira @rix0rrr @aws-cdk-automation