feat(secretsmanager): Specify secret value at creation #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables customers to supply their own secret value in the cases where an auto- generated value is not viable. This exposes the secret value in the cdk output, and CloudFormation template, but not CloudWatch/CloudTrail. fixes #5810
RomainMuller
approved these changes
Aug 11, 2020
RomainMuller
added
the
pr/do-not-merge
rix0rrr
reviewed
Aug 11, 2020
| @@ -103,6 +103,20 @@ export interface SecretProps { | |||
| */ | |||
| readonly secretName?: string; | |||
|
|
|||
| /** | |||
| * **WARNING:** *It is **highly** encouraged to leave this field undefined and allow SecretsManager to create the secret value. | |||
There was a problem hiding this comment.
Putting this here mucks with our doc generation. Put a caption as the first line. For example:
/**
* Literal secret value (DANGEROUS!)
*/
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables customers to supply their own secret value in the cases where an auto-
generated value is not viable. This exposes the secret value in the cdk output,
and CloudFormation template, but not CloudWatch/CloudTrail.
fixes #5810
PR Notes:
secretStringandsecretValueJsonor something, and only allowing one or the other, but wasn't sure it was better. Suggestions on this interface welcome.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license