feat(cloudfront): Distribution - alternate domains #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable users to associate one or more alternate domain names with a distribution. Originally, the plan was for this to come directly from the certificate (if provided); however, the `ICertificate` does not include the certificate domains. Given adding a certificate without specifying the aliases is effectively a no-op (the certificate will never be used), opted to make this an error instead of a warning (a breaking change). Open to discussion and debate on this point. BREAKING CHANGE: `domains` must be specified if `certificate` is provided.
skinny85
approved these changes
Aug 14, 2020
Courtesy Adam Co-authored-by: Adam Ruka <adamruka@amazon.com>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable users to associate one or more alternate domain names with a
distribution. Originally, the plan was for this to come directly from the
certificate (if provided); however, the
ICertificatedoes not include thecertificate domains.
Given adding a certificate without specifying the aliases is effectively a
no-op (the certificate will never be used), opted to make this an error instead
of a warning (a breaking change). Open to discussion and debate on this point.
BREAKING CHANGE: Distribution:
.domainsmust be specified ifcertificateis provided.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license