feat(rds): CloudWatch logs exports for DB clusters #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables exporting database cluster logs to CloudWatch logs. fixes #7810
skinny85
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Nice and simple! I would love to see some validations of the values on a per-engine type basis, and maybe a class with some constants for the common ones, but we can always add this later.
Adding do-not-merge so that Shiv can take a look when he has the time.
njlynch
added a commit
that referenced
this pull request
Aug 18, 2020
This builds on #9772 to add validation for the types of logs that are available on each cluster type (by engine). Notes: * Currently a draft: I want feedback on this approach before either adding some constants for ease-of-use and porting a similar approach to instances. * This is built off of #9772, so includes the changes from #9772 while it is pending a push/merge.
shivlaks
approved these changes
Aug 18, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2020
This builds on #9772 to add validation for the types of logs that are available on each cluster type (by engine). Notes: * Currently a draft: I want feedback on this approach before either adding some constants for ease-of-use and porting a similar approach to instances. * This is built off of #9772, so includes the changes from #9772 while it is pending a push/merge. * Added pr-linter/exempt-readme label (for now) as the current change is validation only. Will add README changes if/when this includes some usable constants. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua
pushed a commit
to misterjoshua/aws-cdk
that referenced
this pull request
Aug 19, 2020
Enables exporting database cluster logs to CloudWatch logs. Fixes aws#7810 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua
pushed a commit
to misterjoshua/aws-cdk
that referenced
this pull request
Aug 19, 2020
This builds on aws#9772 to add validation for the types of logs that are available on each cluster type (by engine). Notes: * Currently a draft: I want feedback on this approach before either adding some constants for ease-of-use and porting a similar approach to instances. * This is built off of aws#9772, so includes the changes from aws#9772 while it is pending a push/merge. * Added pr-linter/exempt-readme label (for now) as the current change is validation only. Will add README changes if/when this includes some usable constants. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables exporting database cluster logs to CloudWatch logs.
Fixes #7810
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license