Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): grantConnect for database instances #9887

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 21, 2020

As a follow-on to enabling IAM database auth, this change makes it easier to
grant a user/role access to the database via policy.

fixes #1558


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

As a follow-on to enabling IAM database auth, this change makes it easier to
grant a user/role access to the database via policy.

fixes #1558
@njlynch njlynch requested a review from a team August 21, 2020 09:54
@njlynch njlynch self-assigned this Aug 21, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 21, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e893828 into master Aug 24, 2020
@mergify mergify bot deleted the njlynch/rds-iam-db-auth branch August 24, 2020 12:56
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 463f7d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kevchentw
Copy link

Is it possible to enable IAM database auth for database cluster or it is for instance database only?

I have tried to get instance from cluster and grantConnect, but it only create rds-db:connect policy without enable IAM Auth on rds instance.

const cluster = new rds.DatabaseCluster(app, `my-rds`, {
    instances: 2,
    .....
}
readerDatabaseInstance = rds.DatabaseInstance.fromDatabaseInstanceAttributes(app, `apt-${stage}-pitlane-rds-instance-reader`, {
  instanceEndpointAddress: cluster.clusterReadEndpoint.hostname,
  instanceIdentifier: cluster.instanceIdentifiers[0],
  port: cluster.clusterReadEndpoint.port,
  securityGroups: [sg]
})
writerDatabaseInstance = rds.DatabaseInstance.fromDatabaseInstanceAttributes(app, `apt-${stage}-pitlane-rds-instance-writer`, {
  instanceEndpointAddress: cluster.clusterEndpoint.hostname,
  instanceIdentifier: cluster.instanceIdentifiers[1],
  port: cluster.clusterEndpoint.port,
  securityGroups: [sg]
})
readerDatabaseInstance.grantConnect(xxx.taskRole)
writerDatabaseInstance.grantConnect(xxx.taskRole)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS: Support enabling IAM DATABASE Authentication
4 participants