feat(rds): add support for joining instance to domain #9943
Conversation
Added new properties to be able to join instance to a domain. closes aws#9869
There was a problem hiding this comment.
This is an extremely high-quality contribution @ctaylor-osv , really kudos on the code quality!
I have one thing I want changed before I'll give the "ShipIt'.
Thanks a lot!
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
| public bindToInstance(_scope: core.Construct, _options: InstanceEngineBindOptions): InstanceEngineConfig { | ||
| const config = super.bindToInstance(_scope, _options); | ||
| if (_options.domain) { | ||
| public bindToInstance(scope: core.Construct, options: InstanceEngineBindOptions): InstanceEngineConfig { |
There was a problem hiding this comment.
Sorry, was trying to model off of the bindToInstance method from the SqlServerInstanceEngineBase class which has the parameters with underscores. Is that because the method in that class doesn't use them?
There was a problem hiding this comment.
Yes, exactly 🙂. No worries!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Added new properties to be able to join instance to a domain.
closes #9869
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license